Skip to content

Conversation

@kgyrtkirk
Copy link

No description provided.

<argLine>-Duser.timezone=UTC</argLine>
<argLine>
-Duser.timezone=UTC
--add-opens=java.base/sun.nio.ch=ALL-UNNAMED
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would we want the full set?

--add-exports=java.base/jdk.internal.misc=ALL-UNNAMED \
--add-exports=java.base/jdk.internal.ref=ALL-UNNAMED \
--add-opens=java.base/java.nio=ALL-UNNAMED \
--add-opens=java.base/sun.nio.ch=ALL-UNNAMED \
--add-opens=java.base/jdk.internal.ref=ALL-UNNAMED \
--add-opens=java.base/java.io=ALL-UNNAMED \
--add-opens=java.base/java.lang=ALL-UNNAMED \
--add-opens=jdk.management/com.sun.management.internal=ALL-UNNAMED

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to remain conservative ... but sure - it can't hurt :)
added them to the pom.xml

pom.xml Outdated
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
<scope>test</scope>
</dependency>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to remove this guava dependency to get the project to build with mvn package. It gets inherited from Druid itself at compile, test, and runtime when removed. But when it's here, it's only present during test. I suppose including it as provided could also work.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also seen some wierd exception - but this is not necessary ; I've removed a few more unnecessary deps

@kgyrtkirk
Copy link
Author

another way to do somewhat the same is to use the druid pom as parent - that way almost everything is configured just like in the main project - however that also configures and enables checkstyle / pmd / etc which can't really operate without their configs....

not sure if that would be a more preferred way for this project....

@kgyrtkirk kgyrtkirk requested a review from gianm April 30, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants