Revised Swedish translation #597
Conversation
Signed-off-by: Samuel Rinnetmäki <[email protected]>
daniel-mader
left a comment
daniel-mader
left a comment
There was a problem hiding this comment.
Hey @samuelmr! Thanks a lot for the contribution! 👍 It looks like you might have worked on a previous version of the translation file. I left some comments where the "technical part" (not your updated translations) of the file seems to be reverted.
| @@ -1,9 +1,9 @@ | |||
| import type { Translation } from '../i18n-types'; | |||
| import type { BaseTranslation } from '../i18n-types'; | |||
There was a problem hiding this comment.
We use English as the "base translation", so all other translations should indeed follow the Translation type. This proposed change should be reverted.
There was a problem hiding this comment.
Agreed. Our Swedish translator has indeed used the previous translation as the base, which is probably the reason why some things are out of sync with the current code.
Can you fix this, or should I modify the PR? (I probably don't have time this week.)
There was a problem hiding this comment.
@samuelmr I don't think I have the permissions to edit this PR directly.
| ONBOARDING: { | ||
| WELCOME: { | ||
| GREETING: 'Välkommen till', | ||
| GREETING: 'Välkommen', |
There was a problem hiding this comment.
This is rendered as "Welcome to UniMe" in the final app in order to greet the user on the first screen. When using only "Välkommen", it would render as "Välkommen UniMe". Is that intended? Or should it stay at "Välkommen till UniMe"?
There was a problem hiding this comment.
"Välkommmen till" is the correct translation.
| TITLE: 'Aktivera {type}', | ||
| DESCRIPTION: 'Vill du ställa in {type} för att låsa upp appen?', | ||
| CONFIRM: 'Ja, använd {type}', | ||
| TITLE: 'Aktivera {type:string}', |
There was a problem hiding this comment.
Defining the data type of the variable is only required when providing a BaseTranslation in the i18n library. These changes should be reverted and indeed stay with {type} only.
| }, | ||
| ADD_CREDENTIALS: { | ||
| BUTTON: 'Lägg till', | ||
| NAVBAR_TITLE: 'Lägg till data', |
There was a problem hiding this comment.
Removing all these fields would leave the translations empty.
There was a problem hiding this comment.
This is probably unintended.
2 participants
Description of change
Human-revised version of the previous auto-translation.
Links to any relevant issues
Be sure to reference any related issues by adding
fixes issue #.How the change has been tested
Describe the tests that you ran to verify your changes.
Make sure to provide instructions for the maintainer as well as any relevant configurations.
npm run testDefinition of Done checklist
Add an
xto the boxes that are relevant to your changes.