-
Notifications
You must be signed in to change notification settings - Fork 4
feat: store app password in key store of device, unlock with biometrics #488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 8dc946f.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 49 out of 49 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
identity-wallet/src/state/common/reducers/unlock_storage.rs:26
- [nitpick] Consider extracting the block of code handling the check_password_only flag into a separate helper function to improve readability and maintainability.
if check_password_only.unwrap_or_default() {
|
I've looked into the failing tests and there are 2.5 causes: Edit: it can be simply solved by skipping sending the Authorization Response during tests: #[cfg(not(feature = "test_utils"))]
if provider_manager.send_response(&response).await.is_err() {
info!("failed to send response");
return Err(SendAuthorizationResponseError);
}in both
pub struct CreateNew {
pub name: String,
pub picture: String,
pub theme: AppTheme,
pub password: String,
#[serde(default)]
pub biometrics_enabled: bool,
}2.5 #[tokio::test]
#[serial_test::serial]
async fn test_credential_is_removed_from_appstate_and_from_stronghold_and_image_is_deleted() |
nanderstabel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rust code looks pretty solid, nicely done! Just left some questions and suggestions regarding the translations.
|
@nanderstabel, regarding the failing tests:
|
Description of change
The user can opt-in to use biometrics to unlock the app.
Links to any relevant issues
betato stable #364AppState, prepare data migration path #498isOpenwith optionalopenstore inActionSheet#541How the change has been tested
Describe the tests that you ran to verify your changes.
Make sure to provide instructions for the maintainer as well as any relevant configurations.
Definition of Done checklist
Add an
xto the boxes that are relevant to your changes.