Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix patch for amalgamated main.rs file #2

Open
wants to merge 4 commits into
base: amalgamate
Choose a base branch
from
Open

Fix patch for amalgamated main.rs file #2

wants to merge 4 commits into from

Conversation

ahomescu
Copy link

@ahomescu ahomescu commented Jul 5, 2024

No description provided.

@ahomescu ahomescu requested a review from kkysen July 5, 2024 01:04
kkysen
kkysen approved these changes Jul 5, 2024
View reviewed changes
Copy link
Collaborator

@kkysen kkysen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I got very confused at first thinking the existing diff file was part of the PR change, lol.

Can we merge #1 to main first before merging this?

@ahomescu ahomescu force-pushed the ahomescu/fix_amalgamated branch from 32a2994 to 6aa2c12 Compare July 11, 2024 06:36
@ahomescu
Copy link
Author

LGTM. I got very confused at first thinking the existing diff file was part of the PR change, lol.

Can we merge #1 to main first before merging this?

Right, I didn't realize you had an open PR for the rest of the code. Could you add the fix to that one?

@ahomescu ahomescu mentioned this pull request Jul 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkysen kkysen kkysen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahomescu @kkysen