transpile: Translate enums with newtype structs#1620
transpile: Translate enums with newtype structs#1620Rua wants to merge 2 commits intoimmunant:masterfrom
Conversation
1fd4b08 to
908acb1
Compare
|
It seems that the transpiler is generating working code, but then the refactorer is breaking the imports. I don't know if that's simply a bug in the refactorer, or something else. Edit: wondering if the refactorer is not handling |
|
The errors from refactor don't seem to have gone away. This PR hasn't changed anything about refactor, so is that a bug in the refactorer? |
kkysen
left a comment
There was a problem hiding this comment.
The errors from refactor don't seem to have gone away. This PR hasn't changed anything about refactor, so is that a bug in the refactorer?
Oh sorry, I meant #1623 should help make the error messages legible, but not fix them.
This is likely either a bug in the refactorer, or the refactorer is assuming something about what code the transpiler generates for enums and now can't handle a different translation of enums. If it's the latter, we should probably fix it here.
|
I've not looked at the refactorer code at all yet, so I wouldn't really know where to look for a possible cause. The CI error messages don't give much of a hint. |
@ahomescu, do you have any idea maybe? |
enumsmodule #1525.