transpile: Allow clippy::missing_safety_doc in generated code#1511
transpile: Allow clippy::missing_safety_doc in generated code#1511Rua wants to merge 1 commit intoimmunant:masterfrom
clippy::missing_safety_doc in generated code#1511Conversation
allow pragmasunused_imports and clippy::missing_safety_doc in generated code
|
I see that in order to support clippy pragmas, I first need to make some changes in various places to allow full paths instead of just strings. But before I do all that, is that actually wanted? |
kkysen
left a comment
There was a problem hiding this comment.
Which unused_imports are we generating? If we can reduce those, that'd also be good.
I see that in order to support clippy pragmas, I first need to make some changes in various places to allow full paths instead of just strings. But before I do all that, is that actually wanted?
I don't think this is particularly important, but supporting clippy pragmas should be fine I think.
unused_imports and clippy::missing_safety_doc in generated codeclippy::missing_safety_doc in generated code
|
I've removed the |
kkysen
left a comment
There was a problem hiding this comment.
Wouldn't clippy::missing_safety_doc be a good warning to have, though? When you manually make the codebase safer, you'll want safety docs. And couldn't you suppress this lint just through clippy instead of inline? So I'm not sure this makes sense, but if you have another use case, let me know, as I might've not considered it.
|
My concern is that there are so many of these that it drowns out any other issues, and safety docs are unlikely to be the first thing the user wants to address. So it just adds a lot of noise. When the user is ready to deal with the safety docs, they can re-enable the lint. |
dcd0799 to
351d601
Compare
Allows the
unused_importsandclippy::missing_safety_docin all generated code. There's always a lot of these which makes it harder to see genuine warnings.