fix(mobile): fix text search

[johnstef99]

Fixes #14814

[github-actions]

Label error. Requires exactly 1 of: changelog:.*. Found:

[alextran1502]

if you don't send null, the search will be incorrect

[johnstef99]

why?

[johnstef99]

immich/mobile/lib/services/search.service.dart

Lines 82 to 85 in c3be74c

	originalFileName:
	filter.filename != null && filter.filename!.isNotEmpty
	? filter.filename
	: null,

[alextran1502]

What do you reference there?

[johnstef99]

where the filename filter is being used

[johnstef99]

and the empty string is necessary because if you copyWith null you will get the previous value

[mertalev]

They should be set null. I'm not sure if the server treats an empty string like null in this case, and in general a lack of a value should be represented with null instead of an empty string.

[johnstef99]

@mertalev the server doesn't get an empty string, it gets null, read the referenced code

[johnstef99]

that's what I mean when I said

The SearchService handles it by checking if the strings context and filename are empty.

[mertalev]

Oh, I see. It seems like a weird limitation to not be able to change an earlier value to null. Not sure if there's a better way to handle that, but I guess this is okay for now if there isn't.

[johnstef99]

This commit f59b813 changed how SearchFilter.copyWith handles null value for context and filename but this created this bug #14814 where when you apply other filters the context and filename always get turned into null.

Passing empty string at the context or the filename filter is necessary to remove the filter when the user submits the search field with no text. The SearchService handles it by checking if the strings context and filename are empty.

I think this answers both of the above questions.