chore(web): transcoding settings cleanup #14765
Open
+216
−196
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hello hello and merry christmas 🎄 wanted to leave you a little change i've had in mind for you to look at in the new year
basically, sorting the transcoding settings in the web admin panel into a more logical order, partitioning them into two new accordions (for a total of four), and adding the localisation strings for these new panels. once i can post some screenshots of the new layout here, i'll mark this ready for review
EDIT: i tried building this on my windows 10 laptop to test the changes and... well... it installed over a gigabyte of crap getting thru node, then npm, then typescript, only to fail the sdk build because windows installed a version of ubuntu from 2 years ago that itself could only install a version of node from 2 years before then and it was 2 versions below the prerequisite version. so i installed that with the node apt repo, at which point wsl used up so much memory and overheated the pc into a bsod and i started wondering whether a trivial layout change in immich web was worth destroying my laptop haha
so i'll try to just mimic what it should look like in my next post below, but i am fairly confident it will build correctly since it was just copy+pasting simple tag markup. we have two new accordions and rearrangements within them. notice that there are two transcode policy strings, one title-capitalised and one sentence-capitalised. they are called
transcoding_policy
andtranscoding_transcode_policy
depending on their nestedness, the obvious way round