feat(web): create tag on the fly #14726
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bo0tzz
changed the title
|
Hello, thank you for the PR. Can you help fix the e2e test? |
MehringTing
force-pushed
the
b-feat-create-tag-on-the-fly
branch
2 times, most recently
from
5fa8885 to
34197f8
Compare
| let filteredOptions = $derived.by(() => { | ||
| const _options = options.filter((option) => option.label.toLowerCase().includes(searchQuery.toLowerCase())); | ||
|
|
||
| if (allowCreate && searchQuery !== '' && _options.filter((option) => option.label === searchQuery).length === 0) { |
There was a problem hiding this comment.
This filter doesn't do anything does it? You only want _options.length === 0
| @@ -36,6 +36,8 @@ | |||
| options?: ComboBoxOption[]; | |||
| selectedOption?: ComboBoxOption | undefined; | |||
| placeholder?: string; | |||
| allowCreate?: boolean; | |||
| defaultFirstOption?: boolean; | |||
There was a problem hiding this comment.
Can you help put some comment of what does this props do?
| @@ -50,20 +55,22 @@ | |||
| <FullScreenModal title={$t('tag_assets')} icon={mdiTag} onClose={onCancel}> | |||
| <div class="text-sm"> | |||
| <p> | |||
| <FormatMessage key="tag_not_found_question"> | |||
| <!-- <FormatMessage key="tag_not_found_question"> | |||
There was a problem hiding this comment.
Can you remove this unused code?
There was a problem hiding this comment.
I just tested the PR and it works well.
Can you help address the comments? And what do you think about making a wrapper component for the combobox and adding specific tag creation handling in that wrapper component instead of adding those logics to the combobox?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#12179 (comment)