Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: better observability for geodata import #13931

Merged
merged 1 commit into from
Nov 5, 2024
Merged

chore: better observability for geodata import #13931

merged 1 commit into from
Nov 5, 2024
+6 −1

Conversation

zackpollard
Copy link
Contributor

No description provided.

@zackpollard zackpollard force-pushed the chore/better-geodata-observability branch from 7e16298 to 6d40e57 Compare November 5, 2024 15:58
@mertalev
Copy link
Contributor

mertalev commented Nov 5, 2024

How many lines are there? This is going to be a lot of logs, right? It might be better log at larger intervals.

@zackpollard
Copy link
Contributor Author

How many lines are there? This is going to be a lot of logs, right? It might be better log at larger intervals.

There's 200k entries, so 200 logs, I think this is fine as it only happens on update.

@mertalev
Copy link
Contributor

mertalev commented Nov 5, 2024

Yeah, but this is going to be in a lot of log reports and bury other things. Can you make it run every 10k? It's only 20 lines that way. Or maybe adjust the interval by log level if you think it's important to be able to log more frequently than that.

@zackpollard
Copy link
Contributor Author

Yeah, but this is going to be in a lot of log reports and bury other things. Can you make it run every 10k? It's only 20 lines that way. Or maybe adjust the interval by log level if you think it's important to be able to log more frequently than that.

Sure, I don't really care either way. Just means another statement where we already had one.

@zackpollard zackpollard force-pushed the chore/better-geodata-observability branch from 6d40e57 to c189b41 Compare November 5, 2024 16:14
@zackpollard zackpollard enabled auto-merge (squash) November 5, 2024 16:19
@zackpollard zackpollard merged commit c383e11 into main Nov 5, 2024
36 checks passed
@zackpollard zackpollard deleted the chore/better-geodata-observability branch November 5, 2024 16:20
TimVanOnckelen pushed a commit to TimVanOnckelen/immich that referenced this pull request Nov 5, 2024
@zackpollard @TimVanOnckelen
chore: better observability for geodata import (immich-app#13931)
05a228e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mertalev mertalev mertalev approved these changes

@danieldietzler danieldietzler Awaiting requested review from danieldietzler danieldietzler is a code owner

Assignees
No one assigned
Labels
changelog:skip 🗄️server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zackpollard @mertalev