feat(web): Add Partner Sharing Avatars to Timeline and Info Cards #12413
Conversation
|
Implements Feature Request #7608 |
x24git
requested review from
danieldietzler,
mertalev and
bo0tzz
as code owners
github-actions
bot
added
documentation
|
You might want to rebase - the diff is looking pretty gnarly |
x24git
force-pushed
the
feat/user-avatars-web
branch
from
e9046e8
to
0c3e599
Compare
|
Cleaned up commit history and rebased on main. Thanks @mertalev |
|
Resolved all merge conflicts and test cases. Ready to merge. (Apologies for opening and reopening) |
web/src/lib/components/asset-viewer/asset-viewer-nav-bar.svelte
Outdated
Show resolved
Hide resolved
web/src/lib/stores/users.store.ts
Outdated
There was a problem hiding this comment.
I'm not sure if we need a complete store just for this. I'll let that to the web experts though
There was a problem hiding this comment.
If there is another store that is worth integrating into, I don't think that would be an issue. We do need a store though, otherwise there would be API requests for User info for each thumbnail in the asset view.
x24git
force-pushed
the
feat/user-avatars-web
branch
from
1103a30
to
df65197
Compare
x24git
force-pushed
the
feat/user-avatars-web
branch
from
df65197
to
70a6a25
Compare
|
Maybe it should be placed under Partner Sharing? |
Agreed, updated the PR description with the new placement. Swapped out the Partner Sharing title to a generic Sharing configuration, and then moved partners into an accordion box. Allow for future sharing specific settings to be added in the future. |
Looks good I like that, but it's not my job to decide so let's see what the opinion of the core development team is. |
This Feature adds user avatars to the timeline for both partner sharing, and shared albums.
Timeline
The avatar uses the user's avatar image (if one is set) or the server's information is used to make an avatar using the user's assigned color and first letter of their name.
(In the screenshot below, the partner's icon is an Orange 'T'). Implements a simple store for user data to efficiently pull user data for the timelines.
New Settings
In order to control this feature there is a new setting added in the sharing config (changed from partner sharing to generic sharing).
Asset View
Additionally, there is improvements to the asset view to make it clear the source of the image (either shared, when in an album, or from partner sharing in the main timeline)
Is the companion feature for the same capability set on the mobile app #12089