Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mobile): show stack child in the album page #12279

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

alextran1502
Copy link
Contributor

@alextran1502 alextran1502 commented Sep 3, 2024

This PR fixes the issues of stack information not being properly updated and displayed when the stacked asset is in an album.

Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't a bug it was working as designed

@alextran1502
Copy link
Contributor Author

@jrasm91 This is currently a bug on the mobile app. The sync has two stages: first, getting all the users' assets; second, getting all albums and assets within an album.

The second step is bugging out if the asset is stacked and then put into an album. The response from getting all assets from an album does not contain the stack information, leads to upserting incorrectly information to the local database, and the stack doesn't show the child properly.

Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The solution to the problem is not to change album endpoints to return stack information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants