feat(mobile): Adding filters feature to mobile image editor #12247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you share some screenshots? |
|
@etnoy it's still a draft, I am working on it. Will add all the screenshots when done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit brings a new filter feature to the mobile image editor within the Immich app. The editor works the same as the crop editor that Immich had before and images still get saved to your gallery first.
VID_20240912_205326.mp4
Also, a moment of appreciation to @GabiVlg04 for implementing the filters feature before me. Unfortunately, he couldn’t create a pull request due to breaking changes I made to the editor afterward 🫡. Can’t wait for you all to try this out! Please report issues or feature requests (regarding this page) by creating an issue on Github and pinging my name so I can rectify them quickly! 😃