feat: original-sized previews for non-web-friendly images #28260
eligaotest.yml
on: pull_request
pre-job
4s
Test & Lint Server
1m 37s
Unit Test CLI
22s
Unit Test CLI (Windows)
51s
Test & Lint Web
4m 46s
End-to-End Lint
27s
Medium Tests (Server)
1m 52s
End-to-End Tests (Server & CLI)
3m 18s
End-to-End Tests (Web)
3m 28s
Unit Test Mobile
1m 38s
Unit Test ML
0s
Annotations
14 errors and 9 warnings
|
TypeORM Checks
Process completed with exit code 1.
|
|
Test & Lint Server
Object literal may only specify known properties, and 'fullsizePreview' does not exist in type '{ thumbnail: ImageOptions; preview: ImageOptions; colorspace: Colorspace; extractEmbedded: boolean; fullsize: FullsizeImageOptions; }'.
|
|
Test & Lint Server
Process completed with exit code 2.
|
|
src/services/media.service.spec.ts > MediaService > handleGenerateThumbnails > should generate P3 thumbnails for a wide gamut image:
server/src/services/media.service.spec.ts#L347
AssertionError: expected "spy" to be called 2 times, but got 3 times
❯ src/services/media.service.spec.ts:347:43
|
|
src/services/media.service.spec.ts > MediaService > handleGenerateThumbnails > should generate an image preview in jpeg format:
server/src/services/media.service.spec.ts#L541
AssertionError: expected "spy" to be called 2 times, but got 3 times
❯ src/services/media.service.spec.ts:541:43
|
|
src/services/media.service.spec.ts > MediaService > handleGenerateThumbnails > should generate an image preview in webp format:
server/src/services/media.service.spec.ts#L541
AssertionError: expected "spy" to be called 2 times, but got 3 times
❯ src/services/media.service.spec.ts:541:43
|
|
src/services/media.service.spec.ts > MediaService > handleGenerateThumbnails > should generate an image thumbnail in jpeg format:
server/src/services/media.service.spec.ts#L586
AssertionError: expected "spy" to be called 2 times, but got 3 times
❯ src/services/media.service.spec.ts:586:43
|
|
src/services/media.service.spec.ts > MediaService > handleGenerateThumbnails > should generate an image thumbnail in webp format:
server/src/services/media.service.spec.ts#L586
AssertionError: expected "spy" to be called 2 times, but got 3 times
❯ src/services/media.service.spec.ts:586:43
|
|
src/services/media.service.spec.ts > MediaService > handleGenerateThumbnails > should extract embedded image if enabled and available:
server/src/services/media.service.spec.ts#L632
AssertionError: expected "spy" to be called with arguments: [ undefined, …(1) ]
Received:
1st spy call:
Array [
- undefined,
+ "/original/path.dng",
Object {
"colorspace": "p3",
"processInvalidImages": false,
"size": 1440,
},
]
Number of calls: 1
❯ src/services/media.service.spec.ts:632:37
|
|
src/services/media.service.spec.ts > MediaService > handleGenerateThumbnails > should resize original image if embedded image is too small:
server/src/services/media.service.spec.ts#L648
AssertionError: expected "spy" to be called with arguments: [ …(3) ]
Received:
1st spy call:
Array [
Object {
"data": Array [
105,
109,
97,
103,
101,
32,
100,
97,
116,
97,
],
"type": "Buffer",
},
- ObjectContaining {
- "size": 1440,
+ Object {
+ "colorspace": "p3",
+ "format": "webp",
+ "processInvalidImages": false,
+ "quality": 80,
+ "raw": Object {
+ "channels": 3,
+ "height": 100,
+ "width": 100,
+ },
+ "size": 250,
},
- undefined,
+ "upload/thumbs/user-id/as/se/asset-id-thumbnail.webp",
]
2nd spy call:
Array [
Object {
"data": Array [
105,
109,
97,
103,
101,
32,
100,
97,
116,
97,
],
"type": "Buffer",
},
- ObjectContaining {
+ Object {
+ "colorspace": "p3",
+ "format": "jpeg",
+ "processInvalidImages": false,
+ "quality": 80,
+ "raw": Object {
+ "channels": 3,
+ "height": 100,
+ "width": 100,
+ },
"size": 1440,
},
- undefined,
+ "upload/thumbs/user-id/as/se/asset-id-preview.jpeg",
]
3rd spy call:
Array [
Object {
"data": Array [
105,
109,
97,
103,
101,
32,
100,
97,
116,
97,
],
"type": "Buffer",
},
- ObjectContaining {
- "size": 1440,
+ Object {
+ "colorspace": "p3",
+ "format": "jpeg",
+ "processInvalidImages": false,
+ "quality": 80,
+ "raw": Object {
+ "channels": 3,
+ "height": 100,
+ "width": 100,
+ },
+ "size": undefined,
},
- undefined,
+ "upload/thumbs/user-id/as/se/asset-id-fullsize.jpeg",
]
Number of calls: 3
❯ src/services/media.service.spec.ts:648:43
|
|
src/services/media.service.spec.ts > MediaService > handleGenerateThumbnails > should resize original image if embedded image not found:
server/src/services/media.service.spec.ts#L668
AssertionError: expected "spy" to be called with arguments: [ '/original/path.dng', …(1) ]
Received:
1st spy call:
Array [
"/original/path.dng",
Object {
"colorspace": "p3",
"processInvalidImages": false,
+ "size": 1440,
},
]
Number of calls: 1
❯ src/services/media.service.spec.ts:668:37
|
|
src/services/media.service.spec.ts > MediaService > handleGenerateThumbnails > should resize original image if embedded image extraction is not enabled:
server/src/services/media.service.spec.ts#L683
AssertionError: expected "spy" to be called with arguments: [ '/original/path.dng', …(1) ]
Received:
1st spy call:
Array [
"/original/path.dng",
Object {
"colorspace": "p3",
"processInvalidImages": false,
+ "size": 1440,
},
]
Number of calls: 1
❯ src/services/media.service.spec.ts:683:37
|
|
src/services/media.service.spec.ts > MediaService > handleGenerateThumbnails > should process invalid images if enabled:
server/src/services/media.service.spec.ts#L704
AssertionError: expected "spy" to be called with arguments: [ …(3) ]
Received:
1st spy call:
Array [
Object {
"data": Array [
105,
109,
97,
103,
101,
32,
100,
97,
116,
97,
],
"type": "Buffer",
},
- ObjectContaining {
+ Object {
+ "colorspace": "p3",
+ "format": "webp",
"processInvalidImages": true,
+ "quality": 80,
+ "raw": Object {
+ "channels": 3,
+ "height": 100,
+ "width": 100,
},
- "upload/thumbs/user-id/as/se/asset-id-converted.jpeg",
+ "size": 250,
+ },
+ "upload/thumbs/user-id/as/se/asset-id-thumbnail.webp",
]
2nd spy call:
Array [
Object {
"data": Array [
105,
109,
97,
103,
101,
32,
100,
97,
116,
97,
],
"type": "Buffer",
},
- ObjectContaining {
+ Object {
+ "colorspace": "p3",
+ "format": "jpeg",
"processInvalidImages": true,
+ "quality": 80,
+ "raw": Object {
+ "channels": 3,
+ "height": 100,
+ "width": 100,
},
- "upload/thumbs/user-id/as/se/asset-id-converted.jpeg",
+ "size": 1440,
+ },
+ "upload/thumbs/user-id/as/se/asset-id-preview.jpeg",
]
3rd spy call:
Array [
Object {
"data": Array [
105,
109,
97,
103,
101,
32,
100,
97,
116,
97,
],
"type": "Buffer",
},
- ObjectContaining {
+ Object {
+ "colorspace": "p3",
+ "format": "jpeg",
"processInvalidImages": true,
+ "quality": 80,
+ "raw": Object {
+ "channels": 3,
+ "height": 100,
+ "width": 100,
},
- "upload/thumbs/user-id/as/se/asset-id-converted.jpeg",
+ "size": undefined,
+ },
+ "upload/thumbs/user-id/as/se/asset-id-fullsize.jpeg",
]
Number of calls: 3
❯ src/services/media.service.spec.ts:704:43
|
|
End-to-End Tests (Web)
Process completed with exit code 1.
|
|
pre-job
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
ShellCheck
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Unit Test CLI
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
End-to-End Lint
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
OpenAPI Clients
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
TypeORM Checks
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Test & Lint Server
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Unit Test Mobile
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Test & Lint Web
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|