fix(rbac): useEffect deleted

imjulianeral · Sep 2, 2021 · f596a2a · f596a2a
1 parent 40583b6
commit f596a2a
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 34 deletions.
diff --git a/example/ts-fire-example/package-lock.json b/example/ts-fire-example/package-lock.json
diff --git a/example/ts-fire-example/package.json b/example/ts-fire-example/package.json
@@ -11,7 +11,7 @@
   "dependencies": {
     "firebase": "^8.7.0",
     "next": "11.0.1",
-    "next-shield": "^2.0.10",
+    "next-shield": "^2.0.11",
     "react": "17.0.2",
     "react-dom": "17.0.2",
     "react-firebase-hooks": "^3.0.4",

diff --git a/src/components/NextShield.tsx b/src/components/NextShield.tsx
@@ -65,35 +65,23 @@ export function NextShield<
     RBAC && userRole && verifyPath(RBAC[userRole].grantedRoutes, pathname)
   const access = getAccessRoute(RBAC, userRole, accessRoute) as string
 
-  console.log({
-    userRole,
-    access,
-    isAuth,
-    isLoading,
-    loginRoute,
-    pathIsPrivate,
-    pathIsPublic,
-    pathIsHybrid,
-    pathIsAuthorized,
-  })
-
-  useEffect(() => {
-    if (!isAuth && !isLoading && pathIsPrivate) replace(loginRoute)
-    if (isAuth && !isLoading && pathIsPublic) replace(access)
-    if (isAuth && userRole && !isLoading && !pathIsHybrid && !pathIsAuthorized)
-      replace(access)
-  }, [
-    replace,
-    userRole,
-    access,
-    isAuth,
-    isLoading,
-    loginRoute,
-    pathIsPrivate,
-    pathIsPublic,
-    pathIsHybrid,
-    pathIsAuthorized,
-  ])
+  // useEffect(() => {
+  //   if (!isAuth && !isLoading && pathIsPrivate) replace(loginRoute)
+  //   if (isAuth && !isLoading && pathIsPublic) replace(access)
+  //   if (isAuth && userRole && !isLoading && !pathIsHybrid && !pathIsAuthorized)
+  //     replace(access)
+  // }, [
+  //   replace,
+  //   userRole,
+  //   access,
+  //   isAuth,
+  //   isLoading,
+  //   loginRoute,
+  //   pathIsPrivate,
+  //   pathIsPublic,
+  //   pathIsHybrid,
+  //   pathIsAuthorized,
+  // ])
 
   if (
     ((isLoading || !isAuth) && pathIsPrivate) ||

diff --git a/src/libs/routes.ts b/src/libs/routes.ts
@@ -13,5 +13,5 @@ export function getAccessRoute(
 
   if (RBAC && userRole) return RBAC[userRole].accessRoute
 
-  return undefined
+  return '/'
 }