fix(userrole): fix userRole type to handle undefined state

imjulianeral · Sep 7, 2021 · 25d6153 · 25d6153
1 parent 9cc9988
commit 25d6153
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/src/components/NextShield.tsx b/src/components/NextShield.tsx
@@ -88,9 +88,8 @@ export function NextShield<
     ((isLoading || isAuth) && pathIsPublic) ||
     ((isLoading || userRole) && !pathIsAuthorized) ||
     (isLoading && pathIsHybrid)
-  ) {
+  )
     return <>{LoadingComponent}</>
-  }
 
   return <>{children}</>
 }
diff --git a/src/types/props.ts b/src/types/props.ts
@@ -439,5 +439,5 @@ export type NextShieldProps<
    *   )
    * ```
    */
-  userRole: string
+  userRole: string | undefined
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -439,5 +439,5 @@ export type NextShieldProps< @@
        *   )
        * ```
        */
-      userRole: string
+      userRole: string | undefined
     }