altered logic

imjordanxd · Sep 15, 2024 · 825c2fc · 825c2fc
1 parent d6a6fb4
commit 825c2fc
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 17 deletions.
diff --git a/lib/rules/no-useless-constructor.js b/lib/rules/no-useless-constructor.js
@@ -4,6 +4,8 @@
  */
 "use strict";
 
+const astUtils = require("./utils/ast-utils");
+
 //------------------------------------------------------------------------------
 // Helpers
 //------------------------------------------------------------------------------
@@ -185,14 +187,10 @@ module.exports = {
  {
  messageId: "removeConstructor",
  *fix(fixer) {
- const previousToken = context.sourceCode.getTokenBefore(node);
  const nextToken = context.sourceCode.getTokenAfter(node);
+ const addSemiColon = nextToken.type === "Punctuator" && nextToken.value === "[" && astUtils.needsPrecedingSemicolon(context.sourceCode, node);
 
- if (previousToken && previousToken.type !== "Punctuator" && nextToken && nextToken.type !== "Punctuator") {
- yield fixer.insertTextAfter(previousToken, ";");
- }
-
- yield fixer.remove(node);
+ yield fixer.replaceText(node, addSemiColon ? ";" : "");
  }
  }
  ]

diff --git a/tests/lib/rules/no-useless-constructor.js b/tests/lib/rules/no-useless-constructor.js
@@ -135,17 +135,6 @@ ruleTester.run("no-useless-constructor", rule, {
  }]
  }]
  },
- {
- code: "class A {\nfoo = 5\nconstructor() {}\nbar() {}\n}",
- languageOptions: { ecmaVersion: 2022 },
- errors: [{
- ...error,
- suggestions: [{
- messageId: "removeConstructor",
- output: "class A {\nfoo = 5;\n\nbar() {}\n}"
- }]
- }]
- },
  {
  code: "class A { foo = \"bar\"\nconstructor() { }\n[0]() { } }",
  languageOptions: { ecmaVersion: 2022 },