Skip to content

Commit

Permalink
Update cran-comments.md
Browse files Browse the repository at this point in the history
  • Loading branch information
ghim committed May 16, 2019
1 parent 86d1486 commit c0eff3c
Showing 1 changed file with 24 additions and 15 deletions.
39 changes: 24 additions & 15 deletions cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,35 +5,44 @@ This is a resubmission. In this version I have:

* Improved the DESCRIPTION description of the package

* Removed web references to each city bike website in Norway in DESCRIPTION
description because I think it made the description ugly. To compensate, I
have added web references to each City Bike website in the object
documentation for each function, and also in README.md, which I hope is
acceptable.
* The web reference for the license, NLOD 2.0, stays.

* Updated README.md

* Updated NEWS.md

* Updated object documentation

* Moved "data.table" from "Imports" to "Suggests" in DESCRIPTION

* Removed "magrittr" from "Imports"

* Removed web references to each city bike website in Norway in DESCRIPTION
description because I think it made the description ugly. To compensate, I
have added web references to each City Bike website in the object
documentation for each function, and also in README.md, which I hope is
acceptable.
* The web reference for the license, NLOD 2.0, stays.
* Updated all exported functions to use `switch()` instead of an "if-else"
control structure.

* Changed the version number to 0.1.1 from 0.2.1 as I have fixed some
bugs, and made minor changes to the package as mentioned above.
* The changes do not break any existing code for R users who have
already installed the package.

* Repaired bysykkel functions that broke due to website and API changes
at Oslo City Bike.
* Updated `dl_trips_data()` to retrieve CSV-files for legacy city bike data
for Oslo, which would be downloaded as ZIP-files in the previous package
version.

* Added `bysykkel_control_*` functions to better detect errors, and
provide better more clear error messages that will (hopefully) better
provide informative error messages that will (hopefully) better
inform the user of what errors were made.

* Repaired bysykkel functions that broke down due to website and API changes
at Oslo City Bike.

* Changed the version number to 0.1.1 from 0.2.3 as I have fixed some
bugs, and made minor changes to the package as mentioned above.
* The changes do not break any existing code for R users who have
already installed the package.

## Test environments
* local Windows install, R 3.5.2
* local Windows install, R 3.5.3
* local OS X install, R 3.5.2

## R CMD check results
Expand Down

0 comments on commit c0eff3c

Please sign in to comment.