Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detach initialization QThread after ImageJ initialized #318

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

gselzer
Copy link
Collaborator

@gselzer gselzer commented Dec 9, 2024

JPype automatically attaches all threads accessing Java, but when we dynamically allocate a thread (as we do during initialization) we need to manually detach it.

Closes #307

@gselzer gselzer added the enhancement New feature or request label Dec 9, 2024
@gselzer gselzer self-assigned this Dec 9, 2024
This seems like the best way to get around Python-SIP/sip#57
@gselzer gselzer force-pushed the detach-init-thread branch 2 times, most recently from 06bbf63 to 6d65400 Compare December 9, 2024 22:28
@gselzer gselzer merged commit 8fb1df2 into main Dec 10, 2024
8 checks passed
@gselzer gselzer deleted the detach-init-thread branch December 10, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Napari doesn't quit when wrapping a local install
1 participant