Attach Points as ROI in Data Translation #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gselzer
force-pushed
the
point-permutations-gui
branch
from
1cd0bf9 to
d3b0787
Compare
|
This pull request has been mentioned on Image.sc Forum. There might be relevant details there: https://forum.image.sc/t/fiji-friends-weekly-dev-update-thread/103718/17 |
gselzer
force-pushed
the
point-permutations-gui
branch
from
296db1f to
7499ebe
Compare
A bump in the recommended version was chosen over the minimum version because the affected components are seldom encountered (transferring a Points layer to the ImageJ UI) and because the errors are non-fatal - the data (image + points) does not get transferred).
gselzer
force-pushed
the
point-permutations-gui
branch
from
7499ebe to
1f2d8cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that napari
Pointslayers are wrapped up into aROITreewhen being passed to ImageJ/Fiji.This PR was separated from #305, and is still a draft, because it causes
ClassCastExceptionsarising from imagej/imagej-legacy#299. We should wait for the fix in imagej/imagej-legacy#310 to be merged and released, before merging this.