This repository has been archived by the owner on Apr 24, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 235
Update & Fix issue #45
Open
FrankWu100
wants to merge
12
commits into
iltercengiz:master
Choose a base branch
from
FrankWu100:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Storyboard to Xcode 5 & iOS7 Fix if iOS 7 Navigation Bar type is Translucent, don’t need to set topLayoutGuide.
Fix if iOS 7 Navigation Bar type is Opaque not Translucent set <code>topLayoutGuide = 0.0</code>.
+1 |
ICViewPager 1.5.1 Merge
Updated screenshot link
Seriously, this should be merged. There have been so many reports of this issue, but still.... |
@csotiriou Agree, and this pull has requests for a long time... I can not understand why not merge. |
Haraguroicha
approved these changes
Feb 9, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PR should be approved, because this upstream of PR have been used in this repo commit at least 3 years and works property, also published on App Store
7f4f799 support iPhone X, else' screen layout. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Storyboard to Xcode 5 & iOS7
Fix if iOS 7 Navigation Bar type is Opaque not Translucent set
topLayoutGuide = 0.0
.