Skip to content

refactor: B2Filter parameters to use 'in' modifier in B2Shapes.cs #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ikpil merged 1 commit into from
Dec 27, 2025
Merged

refactor: B2Filter parameters to use 'in' modifier in B2Shapes.cs #75

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Box2D.NET/B2Shapes.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ internal static float b2GetShapeRadius(B2Shape shape)
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
internal static bool b2ShouldShapesCollide(B2Filter filterA, B2Filter filterB)
internal static bool b2ShouldShapesCollide(in B2Filter filterA, in B2Filter filterB)
{
if (filterA.groupIndex == filterB.groupIndex && filterA.groupIndex != 0)
{
Expand All @@ -52,7 +52,7 @@ internal static bool b2ShouldShapesCollide(B2Filter filterA, B2Filter filterB)
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
internal static bool b2ShouldQueryCollide(B2Filter shapeFilter, in B2QueryFilter queryFilter)
internal static bool b2ShouldQueryCollide(in B2Filter shapeFilter, in B2QueryFilter queryFilter)
{
return (shapeFilter.categoryBits & queryFilter.maskBits) != 0 && (shapeFilter.maskBits & queryFilter.categoryBits) != 0;
}
Expand Down Expand Up @@ -1306,7 +1306,7 @@ internal static void b2ResetProxy(B2World world, B2Shape shape, bool wakeBodies,
/// contacts to be immediately destroyed. However contacts are not created until the next world step.
/// Sensor overlap state is also not updated until the next world step.
/// @see b2ShapeDef::filter
public static void b2Shape_SetFilter(in B2ShapeId shapeId, B2Filter filter)
public static void b2Shape_SetFilter(in B2ShapeId shapeId, in B2Filter filter)
{
B2World world = b2GetWorldLocked(shapeId.world0);
if (world == null)
Expand Down
Loading