Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/exit status #5

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Feature/exit status #5

merged 2 commits into from
Feb 5, 2024

Conversation

BenediktHaas96
Copy link
Collaborator

scenario_runner.py printed the final evaluation of the executed scenario, but always returned True if the scenario could be fully executed, completely disregarding the evaluation.

With these changes the _analyze_scenario function now also returns True if all required criteria are met and False if not.

@BenediktHaas96 BenediktHaas96 self-assigned this Feb 5, 2024
@BenediktHaas96 BenediktHaas96 changed the base branch from master to main February 5, 2024 13:12
cgeller
cgeller approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@cgeller cgeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@BenediktHaas96 BenediktHaas96 merged commit d2a800b into main Feb 5, 2024
4 of 7 checks passed
@BenediktHaas96 BenediktHaas96 deleted the feature/exit-status branch February 5, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgeller cgeller cgeller approved these changes

Assignees

@BenediktHaas96 BenediktHaas96

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BenediktHaas96 @cgeller