Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom location #147

Merged
merged 7 commits into from
Nov 11, 2024

Conversation

ruiiiijiiiiang
Copy link
Contributor

Is your pull request linked to an existing issue?

#143

What is your pull request about?:

Allows user specified location for weather fetching.

@iinsertNameHere
Copy link
Owner

Hey, thx for your PR.. Unfortunately if you look at the tests, they failed to fetch the wether stat. I don't know why they did not fail, will open an issue an look into it..

@ruiiiijiiiiang
Copy link
Contributor Author

Hi @iinsertNameHere, I figured out why the tests were failing. The test config location was "San Francisco", and the space was breaking the wttr.in url. I added a replace(" ", "+") as instructed by wttr.in and it is working now. As for the tests, I noticed that they were passing for me locally because the weather info was cached, so I added a -n to each test script to force a refresh. I'm still not sure why it was passing in the github workflow though, so you might need to further look into that.

@iinsertNameHere
Copy link
Owner

@ruiiiijiiiiang Thanks, for looking in to it!

@iinsertNameHere iinsertNameHere merged commit 773c2a8 into iinsertNameHere:main Nov 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants