Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update pre-commit pylint hook #190

Merged
merged 1 commit into from
Feb 27, 2024
Merged

build: update pre-commit pylint hook #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,5 @@ repos:
name: pylint
entry: pylint
language: system
files: ^src/
types: [python]
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,11 +89,11 @@ To install incendium on your Gateway follow these steps:
1. If you're replacing a previous version, make sure to check Allow Overwrite
1. Click on **Import**

Alternatively you could follow the instructions for cloning the `project` branch directly into `$IGNITION_DIR/data/projects` found [here](https://github.com/ignition-incendium/incendium/tree/project#cloning-this-branch).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick (llm): The updated link for cloning instructions now points to a more specific location, which is helpful for users. However, ensure that the query parameter ?tab=readme-ov-file in the URL is necessary and correctly directs users to the intended section. If it's a typo or not required, it might confuse users or lead to a 404 page.

Alternatively you could follow the instructions for cloning the `project` repo directly into `$IGNITION_DIR/data/projects` found [here](https://github.com/ignition-incendium/project?tab=readme-ov-file#cloning-this-repo).

## Contributing to `incendium`

See [CONTRIBUTING.md](./CONTRIBUTING.md).
See [CONTRIBUTING.md](https://github.com/ignition-incendium/.github/blob/main/CONTRIBUTING.md#contributing-to-incendium).

## Discussions

Expand All @@ -111,4 +111,4 @@ See [LICENSE](./LICENSE).

## Code of conduct

See [CODE_OF_CONDUCT.md](./CODE_OF_CONDUCT.md).
See [CODE_OF_CONDUCT.md](https://github.com/ignition-incendium/.github/blob/main/CODE_OF_CONDUCT.md).
12 changes: 1 addition & 11 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,10 @@ env_list =

[testenv:install]
description = install package
base_python = {[py2]base_python}
base_python = python2.7

[testenv:typecheck]
description = run type check on code base
base_python = {[type]base_python}
skip_install = true
deps =
{[type]deps}
Expand All @@ -21,7 +20,6 @@ commands =

[testenv:stubgen]
description = generate stubs
base_python = {[type]base_python}
skip_install = true
deps =
{[type]deps}
Expand All @@ -30,7 +28,6 @@ commands =

[testenv:style]
description = apply style
base_python = {[py3]base_python}
skip_install = true
deps =
black
Expand All @@ -49,13 +46,6 @@ commands =
allowlist_externals =
bash

[py2]
base_python = python2.7

[py3]
base_python = python3.12

[type]
base_python = {[py3]base_python}
deps =
ignition-api-stubs