Skip to content

Commit

Permalink
build: update pre-commit pylint hook (#190)
Browse files Browse the repository at this point in the history
when pylint is installed isolated from pre-commit, e.g. with pipx,
it flags setup.py with E0401 since setuptools is not found
update tox config
  • Loading branch information
cesarcoatl authored Feb 27, 2024
1 parent e7267fa commit e0ccace
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 14 deletions.
1 change: 1 addition & 0 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,5 @@ repos:
name: pylint
entry: pylint
language: system
files: ^src/
types: [python]
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -89,11 +89,11 @@ To install incendium on your Gateway follow these steps:
1. If you're replacing a previous version, make sure to check Allow Overwrite
1. Click on **Import**

Alternatively you could follow the instructions for cloning the `project` branch directly into `$IGNITION_DIR/data/projects` found [here](https://github.com/ignition-incendium/incendium/tree/project#cloning-this-branch).
Alternatively you could follow the instructions for cloning the `project` repo directly into `$IGNITION_DIR/data/projects` found [here](https://github.com/ignition-incendium/project?tab=readme-ov-file#cloning-this-repo).

## Contributing to `incendium`

See [CONTRIBUTING.md](./CONTRIBUTING.md).
See [CONTRIBUTING.md](https://github.com/ignition-incendium/.github/blob/main/CONTRIBUTING.md#contributing-to-incendium).

## Discussions

Expand All @@ -111,4 +111,4 @@ See [LICENSE](./LICENSE).

## Code of conduct

See [CODE_OF_CONDUCT.md](./CODE_OF_CONDUCT.md).
See [CODE_OF_CONDUCT.md](https://github.com/ignition-incendium/.github/blob/main/CODE_OF_CONDUCT.md).
12 changes: 1 addition & 11 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,10 @@ env_list =

[testenv:install]
description = install package
base_python = {[py2]base_python}
base_python = python2.7

[testenv:typecheck]
description = run type check on code base
base_python = {[type]base_python}
skip_install = true
deps =
{[type]deps}
Expand All @@ -21,7 +20,6 @@ commands =

[testenv:stubgen]
description = generate stubs
base_python = {[type]base_python}
skip_install = true
deps =
{[type]deps}
Expand All @@ -30,7 +28,6 @@ commands =

[testenv:style]
description = apply style
base_python = {[py3]base_python}
skip_install = true
deps =
black
Expand All @@ -49,13 +46,6 @@ commands =
allowlist_externals =
bash

[py2]
base_python = python2.7

[py3]
base_python = python3.12

[type]
base_python = {[py3]base_python}
deps =
ignition-api-stubs

0 comments on commit e0ccace

Please sign in to comment.