Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu entry for Linux #808

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Menu entry for Linux #808

wants to merge 1 commit into from

Conversation

es20490446e
Copy link

No description provided.

@ifedapoolarewaju
Copy link
Collaborator

Thank you for the PR.

How is it meant to work? Is it expected to work with the appImage or deb distributions?

@es20490446e
Copy link
Author

You are welcome ;)

"Install menu entry.sh" is a standalone program that can be executed withing any packaging method, as it was any other terminal command.

It shall be quite obvious to any Linux packager how to use it.

@es20490446e
Copy link
Author

Wait a second, I think there's an issue with that approach. Let me check.

@ifedapoolarewaju
Copy link
Collaborator

ifedapoolarewaju commented Feb 18, 2019

I ask because when users download the .deb or .appimage distributions, this script will not be available to them. Except to users who clone this repo. So I wonder where/when exactly this script comes to play?

Also, the build directory is used by electron-packager when building installation files, so unless the files you added will be used by electron-packager, I'll rather move them to a separate folder

@es20490446e
Copy link
Author

Okay.

@es20490446e
Copy link
Author

I see that in:
https://github.com/ifedapoolarewaju/igdm/releases

The deb files already have a desktop entry. Any idea about how these are generated?

@es20490446e
Copy link
Author

In those entries the icon is missing. Anyway the current one cannot be seen when the task manager has a dark background.

@ifedapoolarewaju
Copy link
Collaborator

The deb files already have a desktop entry. Any idea about how these are generated?

It is created with electron-builder. So maybe we only need to specify some linux related files, so it can add the icon appropriately.

Anyway the current one cannot be seen when the task manager has a dark background.

yes but that's the current IGdm logo.

@es20490446e
Copy link
Author

es20490446e commented Feb 19, 2019

What if the icon was the unofficial Instagram logo at Wikimedia?

Also do you think it would be a good idea if, for clarity, the menu entry was named "IG:dm Instagram Messenger"?

@ifedapoolarewaju
Copy link
Collaborator

What if the icon was the unofficial Instagram logo at Wikimedia?

that means we would need to update it in all fronts (the website, OSX, windows). Is there a png version of the image?

Also do you think it would be a good idea if, for clarity, the menu entry was named "IG:dm Instagram Messenger"?

what exactly does "menu entry" mean in this context?

@es20490446e
Copy link
Author

Making a PNG version is easy with Inkscape.

And with menu entry I mean the ".desktop" file that makes the app icon appear in the application menu. As example.

@ifedapoolarewaju
Copy link
Collaborator

And with menu entry I mean the ".desktop" file that makes the app icon appear in the application menu

Yes, but what is the visual implication of this? Where and how does it appear?

Making a PNG version is easy with Inkscape.

I often have issues converting svg to png while preserving the image quality(visual). But if Inkscape will work, then that's fine.

I am ok with changing to this new logo, however, the headache for me is updating the corresponding osx and windows files with this change. i.e the compatible icns and ico versions of this new logo. If these could also be provided, then I'm happy to merge

@es20490446e
Copy link
Author

That's the question, this icon can appear in so many different places that it has to work well with a wide range of them. On Linux the variety of desktop environments is huge.

The background around the icon could be of any color. So if the icon is too linear, too dark, or too bright, for sure it won't be visible in some common context.

In fact the current one is completely invisible in my dock. It is a dark semi transparent dock that surrounds all the icon. Furthermore the base color of the dock cannot be customized.

I can create the ".icns" file with Cloud Convert, and the ".ico" with Imagemagick.

@ifedapoolarewaju
Copy link
Collaborator

I can create the ".icns" file with Cloud Convert, and the ".ico" with Imagemagick.

I'll be happy to test and merge if so :)

@es20490446e
Copy link
Author

Sorry, but I won't be able to implement this. I'm overloaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants