Skip to content

Conversation

@kesara
Copy link
Member

@kesara kesara commented Mar 10, 2025

Fixes #379

This is a new PR based on @mgax's #406.
New PR was created because main branch has drifted and I couldn't update original PR.

@kesara kesara mentioned this pull request Mar 10, 2025
@kesara kesara requested a review from rjsparks April 1, 2025 03:41
@rjsparks
Copy link
Member

rjsparks commented Apr 1, 2025

Still some conflicts to resolve.

I guess we decided that applying black to the whole codebase here was the right thing to do (it doesn't hide enough history to matter)?

I expect to approve this when the conflicts are resolved

@mgax
Copy link
Contributor

mgax commented Apr 1, 2025

it doesn't hide enough history to matter

It's possible to configure Git (and GitHub) to skip over certain commits in the "blame" view: https://docs.github.com/en/repositories/working-with-files/using-files/viewing-and-understanding-files#ignore-commits-in-the-blame-view. That page has a nice example of how a .git-blame-ignore-revs file might be structured.

@kesara
Copy link
Member Author

kesara commented Apr 2, 2025

@rjsparks I have rebased with main and recompiled dev dependencies. This should resolve any outstanding conflicts.

@kesara kesara merged commit c84e56b into ietf-tools:main Apr 3, 2025
6 checks passed
@kesara kesara deleted the chore/linting2 branch April 3, 2025 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setup linting

3 participants