Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : Resolve drawer wrapper style for side-nav in mobile view #855

Merged

Conversation

raphael3213
Copy link
Contributor

Description

Added styling fot the Ant Design drawer

  • Enable transparency
  • Remove box shadow
  • Increased the width for better transition fluidity
  • Removed the css class as it was not affecting the component

Related Issues

#854

Steps to Test

  1. Visit Home page
  2. Login as admin
  3. Shrink the screen size to minimum or use Dev tools to view the app in mobile
  4. Open the side nav to observe the white background behind the navbar.

Provide steps on how to test the changes introduced in this pull request.

Screenshots (if applicable)

Before :
idura-side-nav-mobile-view-current

After :

idura-side-nav-mobile-view-fixed

Checklist

  • I have tested these changes
  • I have updated the relevant documentation
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the codebase
  • My changes generate no new warnings or errors
  • The title of my pull request is clear and descriptive

Copy link
Member

@salahlalami salahlalami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raphael3213 please to remove margin in left and top , and also remove radius corner (only in mobile view)

@raphael3213
Copy link
Contributor Author

Will do.

@raphael3213
Copy link
Contributor Author

@salahlalami Made the changes to ensure no margin left , top and radius for the side nav on mobile view only. This will only apply when rendering the MobileSidebar component.

idura-side-nav-mobile-padding-removed

@salahlalami salahlalami merged commit 62b4a3b into idurar:dev Dec 1, 2023
1 check passed
@salahlalami
Copy link
Member

@raphael3213 thank you

eltonsoftware pushed a commit to eltonsoftware/idurar-erp-crm that referenced this pull request May 20, 2024
…drawer-fix

Fix  : Resolve drawer wrapper style for side-nav in mobile view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants