Issues/show top records search #846
Closed
+14
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need to throw error when there is no input because we will show first 10 records
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Made changes in two files:
Search.js
Allowing to construct query when entered text is blank rather than throwing error
AutoCompleteAsync.tsx
Changes to hit api and show top 10 records when text is blank
Related Issues
#832
Steps to Test
This solution is generic as per the requirement and it will work on every search field
Screenshots (if applicable)
On Invoice page Before
On Invoice page After
On offer page After
Checklist