Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Resolve incorrect validation message on invalid phone number #845

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

abhigurjeet
Copy link

Description

On Customer page, when we try to add new customer and enter invalid phone number, it displays an error message which says 'Phone does match the pattern regex expression'. I have fixed this error message to display a more user friendly error message 'Please enter a valid phone number.'

Related Issues

Fixes #840: Add user-friendly validation messages for the Phone field on the customer page

Steps to Test

  1. Go to Customer
  2. Click on 'Add new Customer'
  3. Enter invalid phone number or characters in phone field
  4. It will display user friendly error message.

Screenshots (if applicable)

Before:
image

After:
image

Checklist

  • I have tested these changes
  • I have updated the relevant documentation
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the codebase
  • My changes generate no new warnings or errors
  • The title of my pull request is clear and descriptive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants