partial changes review #1520
daverogasecurity-ci.yml
on: push
solhint
23s
coverage
3m 47s
Annotations
10 errors and 13 warnings
|
|
|
solhint:
contracts/test-helpers/RequestValidatorAuthV2Stub.sol#L36
Replace bytes·calldata with ⏎········bytes·calldata⏎····
|
|
solhint:
contracts/test-helpers/RequestValidatorAuthV2Stub.sol#L37
Replace ·groupID:·0,·verifierID:·0· with groupID:·0,·verifierID:·0
|
|
solhint:
contracts/test-helpers/RequestValidatorV2Stub.sol#L38
Replace bytes·calldata with ⏎········bytes·calldata⏎····
|
|
solhint:
contracts/test-helpers/RequestValidatorV2Stub.sol#L39
Replace ·groupID:·0,·verifierID:·0· with groupID:·0,·verifierID:·0
|
|
solhint:
contracts/test-helpers/RequestValidatorV3_2Stub.sol#L56
Line length must be no more than 120 but current length is 126
|
|
solhint:
contracts/test-helpers/RequestValidatorV3_2Stub.sol#L56
Replace bytes·calldata·params with ⏎········bytes·calldata·params⏎····
|
|
solhint:
contracts/test-helpers/RequestValidatorV3_2Stub.sol#L61
Line length must be no more than 120 but current length is 125
|
|
solhint:
contracts/test-helpers/RequestValidatorV3_2Stub.sol#L61
Replace ·IRequestValidator.RequestParams({·groupID:·credAtomicQuery.groupID,·verifierID:·credAtomicQuery.verifierID with ⏎············IRequestValidator.RequestParams({⏎················groupID:·credAtomicQuery.groupID,⏎················verifierID:·credAtomicQuery.verifierID⏎···········
|
|
solhint:
contracts/test-helpers/RequestValidatorV3Stub.sol#L56
Line length must be no more than 120 but current length is 126
|
|
solhint
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
solhint:
contracts/AlwaysRevert.sol#L8
Use Custom Errors instead of revert statements
|
|
solhint:
contracts/Create2AddressAnchor.sol#L4
Code contains empty blocks
|
|
solhint:
contracts/cross-chain/CrossChainProofValidator.sol#L86
Use Custom Errors instead of require statements
|
|
solhint:
contracts/cross-chain/CrossChainProofValidator.sol#L87
Use Custom Errors instead of require statements
|
|
solhint:
contracts/cross-chain/CrossChainProofValidator.sol#L120
Use Custom Errors instead of require statements
|
|
solhint:
contracts/cross-chain/CrossChainProofValidator.sol#L121
Use Custom Errors instead of require statements
|
|
solhint:
contracts/cross-chain/CrossChainProofValidator.sol#L216
Use Custom Errors instead of revert statements
|
|
solhint:
contracts/cross-chain/CrossChainProofValidator.sol#L222
Error message for revert is too long: 70 counted / 64 allowed
|
|
solhint:
contracts/cross-chain/CrossChainProofValidator.sol#L222
Use Custom Errors instead of revert statements
|
|
solhint:
contracts/identitytreestore/IdentityTreeStore.sol#L43
Constant name must be in capitalized SNAKE_CASE
|
|
coverage
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
coverage
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|