Skip to content

Conversation

@lindsayad
Copy link
Member

Reverts #30135

Apparently this did not help the Griffin team achieve the capability they want, it decreases encapsulation, and it breaks some of @dschwen's work

@lindsayad lindsayad marked this pull request as ready for review April 14, 2025 23:13
@moosebuild
Copy link
Contributor

Job Documentation, step Docs: sync website on 2c7480a wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

Job Coverage, step Generate coverage on 2c7480a wanted to post the following:

Framework coverage

838e6c #30325 2c7480
Total Total +/- New
Rate 85.29% 85.29% -0.00% 100.00%
Hits 110049 110046 -3 1
Misses 18985 18985 - 0

Diff coverage report

Full coverage report

Modules coverage

Inconsistent report tags were found between the head and base reports.
This can happen when reports are missing from either the head or the base.

Inconsistent tags:
module-chemical_reactions
module-chemical_reactions-parallel
module-chemical_reactions-recover
module-combined
module-contact
module-contact-parallel
module-electromagnetics
module-electromagnetics-parallel
module-electromagnetics-recover
module-external_petsc_solver
module-external_petsc_solver-parallel
module-external_petsc_solver-recover
module-fluid_properties
module-fluid_properties-parallel
module-fluid_properties-recover
module-fsi
module-fsi-parallel
module-fsi-recover
module-functional_expansion_tools
module-functional_expansion_tools-parallel
module-functional_expansion_tools-recover
module-geochemistry
module-geochemistry-parallel
module-heat_transfer
module-heat_transfer-parallel
module-heat_transfer-recover
module-level_set
module-level_set-parallel
module-misc
module-misc-parallel
module-misc-recover
module-navier_stokes
module-navier_stokes-parallel
module-navier_stokes-recover
module-optimization
module-optimization-parallel
module-optimization-recover
module-peridynamics
module-peridynamics-parallel
module-phase_field
module-phase_field-parallel
module-porous_flow
module-porous_flow-parallel
module-porous_flow-recover
module-ray_tracing
module-ray_tracing-parallel
module-ray_tracing-recover
module-rdg
module-rdg-parallel
module-reactor
module-reactor-parallel
module-reactor-recover
module-richards
module-scalar_transport
module-scalar_transport-parallel
module-scalar_transport-recover
module-solid_mechanics
module-solid_mechanics-parallel
module-solid_properties
module-solid_properties-parallel
module-solid_properties-recover
module-stochastic_tools
module-stochastic_tools-parallel
module-subchannel
module-subchannel-parallel
module-subchannel-recover
module-thermal_hydraulics
module-thermal_hydraulics-parallel
module-thermal_hydraulics-recover
module-xfem
module-xfem-parallel

Full coverage reports

Reports

This comment will be updated on new commits.

@lindsayad lindsayad requested a review from dschwen April 15, 2025 04:02
@lindsayad lindsayad self-assigned this Apr 15, 2025
Copy link
Member

@dschwen dschwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have confirmed that this fixes my issue.

@loganharbour
Copy link
Member

Will merge once https://civet.inl.gov/event/228492/ gets in.

@loganharbour loganharbour merged commit 5e63aaa into next Apr 16, 2025
50 checks passed
@loganharbour loganharbour deleted the revert-30135-restart_old branch April 16, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants