-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Update NEML2, add NEML2 build script, add NEML2 to moose-dev container #30190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1ad43b6 to
d17b948
Compare
|
@loganharbour This is one of the things we discussed about. I believe we need to make some changes to civet recipe to call |
loganharbour
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First run through. Mostly minor. I can create a step for the cases that use neml2 to run update_and_rebuild_neml2.sh for just this PR
modules/solid_mechanics/include/neml2/interfaces/NEML2ModelInterface.h
Outdated
Show resolved
Hide resolved
reverendbedford
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get GPU nodes on civet? If so we could do an "actual" StaticHybridScheduler test with a gpu and the cpu.
Yep, we can. |
7d12f1c to
0bc1661
Compare
8442a43 to
68ab01d
Compare
4713d57 to
5322864
Compare
764dd84 to
3a5c4c4
Compare
3a5c4c4 to
609f420
Compare
0ce6a80 to
93c87ce
Compare
ad9b655 to
e3694b0
Compare
|
Job Coverage, step Verify coverage on 087cffa wanted to post the following: The following coverage requirement(s) failed:
|
b9d30b5 to
4c12db6
Compare
This update mainly does two things: - Switch neml2 from gnu-make to update_and_rebuild_neml2.sh - Add support for work dispatchers The switch to update_and_rebuild_neml2.sh is needed because - NEML2 could be bringing in some additional dependencies in the future - NEML2 may generate files at configure time - This makes it easier to build binaries and ship NEML2 in containers While the same can be managed by the MOOSE make-based build system, it is easier to maintain and manage if we just rely on NEML2's own CMake scripts, in the long run. List of changes - Added scripts/update_and_rebuild_neml2.sh - Update neml2.mk - Update neml2 submodule - Add support for dispatchers - Add documentation and tests for dispatchers - Handle default dtype; we no longer manipulate torch default dtype outside NEML2 region - Fix --parse-neml2-only cli arg ref idaholab#29579 Co-authored-by: Logan Harbour <[email protected]>
4c12db6 to
d2f1e19
Compare
da571f1 to
a3e085e
Compare
a3e085e to
1c927f4
Compare
|
Job Precheck, step Versioner verify on 1c927f4 wanted to post the following: Versioner templatesFound 16 templates, 0 failed Versioner influential filesFound 56 influential files, 2 changed, 5 added, 0 removed
Versioner versionsFound 10 packages, 1 changed, 0 failed
|
|
Job Clang min debug on 1c927f4 : invalidated by @hugary1995 unrelated timeout -- let's retry |
This update mainly does two things:
The switch to update_and_rebuild_neml2.sh is needed because
While the same can be managed by the MOOSE make-based build system, it is easier to maintain and manage if we just rely on NEML2's own CMake scripts, in the long run.
List of changes
ref #29579