Add net462 targeting #872
Open
Add net462 targeting #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahma
force-pushed
the
net-462-support
branch
7 times, most recently
from
92ca51b
to
0a33619
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #872 +/- ##
==========================================
- Coverage 74.78% 74.62% -0.16%
==========================================
Files 72 75 +3
Lines 8535 8572 +37
==========================================
+ Hits 6383 6397 +14
- Misses 2152 2175 +23 ☔ View full report in Codecov by Sentry. |
|
@piksel can you please take a look, this PR should fix GH Actions pipelines and adds the requested net462 target which should be quite safe addition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not that much of a maintenance burden and will remove some compatibility issues for folks still on full framework. SharpZipLib 2.0 could drop support if deemed so.
Also had to update testing dependencies to get NET 8 support.
I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.
fixes #853
fixes #863