Pass ByRef parameters of parent into hoisted function by ref #1126
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Input:
Erroneous output:
Solution
Analyze arguments in
HoistAndCallLocalFunctionAsync
, if any are ByRef parameters, create an ArgumentList an a ParameterList to use in the local function we are about to create.Currently, I'm passing
null
for theParameterList
fromCommonConversions.cs/ConvertEqualsValueClauseSyntaxAsync()
- so there is no change in behavior. It might be worth analyzing what happens there and maybe make a similar adjustment (I haven't spent much time on that).