Differentiate between statics in setters and getters #1124
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#1054: Statics with same name in getter and setter cause a CONVERSION ERROR
Solution
The solution is basically to store accessor kind in every
IdentifierNameSyntax
of a static, and to use that value later when doing the renaming.Currently, it creates
_Prop_b
and_Prop_b1
, which is fine, but it would be nicer to get_Prop_Get_b
and_Prop_Set_b
instead. This is easy to achieve if every static from a property would get that infix. It's a bit more cumbersome if only those with duplicate name would get one.