Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always use RefConversion.PreAssigment for consts #1120

Merged
merged 3 commits into from
Jul 22, 2024
Merged

Always use RefConversion.PreAssigment for consts #1120

merged 3 commits into from
Jul 22, 2024

Conversation

TymurGubayev
Copy link
Contributor

Problem

#1106: ByRef temporary variable is assigned back into a constant

Solution

  • Only a minor change in GetRefConversion
  • At least one test covering the code changed

@GrahamTheCoder GrahamTheCoder merged commit cf2d4aa into icsharpcode:master Jul 22, 2024
2 checks passed
@TymurGubayev TymurGubayev deleted the fix/RefConstArgument/1 branch July 23, 2024 09:19
@TymurGubayev TymurGubayev mentioned this pull request Jul 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TymurGubayev @GrahamTheCoder