Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use TokenContext when creating modifiers for a DeclareStatementSyntax #1114

Merged
merged 1 commit into from
Jul 18, 2024
Merged

use TokenContext when creating modifiers for a DeclareStatementSyntax #1114

merged 1 commit into from
Jul 18, 2024

Conversation

TymurGubayev
Copy link
Contributor

@TymurGubayev TymurGubayev commented Jul 18, 2024 •
edited by GrahamTheCoder
Loading

Problem

Fixes #1109
"Default visibility on Declared members isn't adjusted"

Solution

Get modifiers in a similar manner to how MethodStatementSyntax is analyzed (use GetMemberContext(node)).

@GrahamTheCoder GrahamTheCoder merged commit 10af52f into icsharpcode:master Jul 18, 2024
2 checks passed
@TymurGubayev TymurGubayev deleted the fix/DeclareMethodVisibility branch July 19, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VB -> C#: Default visibility on Declared members isn't adjusted
2 participants
@TymurGubayev @GrahamTheCoder