Make HighlightingRule extensible so rules aren't required to use Regex #401
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
IHighlightingRule
so developers can implement custom rules that don't use a simple regex pattern. As part of this, I had to make a simpleRuleMatch
type to replace the uses ofSystem.Text.RegularExpressions.Match
instances as I needed a way for a custom implmentation to still return match results.Here's an example of a custom
IHighlightingRule
I needed: https://gist.github.com/GSonofNun/f5a97b24bb9d57c06c723a7bc02940a0This rule allows me to highlight delimiter separated values, giving a color to each column of values, and even lets me change the font weight and underline of certain lines.
I think these changes greatly expands the scope of possibilities for HighlightingRules.