Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Adjust locomotion function for dynamic kick #28

Open
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

hiikariri
Copy link
Contributor

@hiikariri hiikariri commented Jun 23, 2024

Jira Link:

Description

Mainly change the function for positioning, so when dynamic kick is allowed, the range of pan and tilt is adjusted to allow wider range of pan tilt, thus making positioning easier. The tilt range is exponentially mapped because the relationship between pan and tilt for same ball distance from the robot, but different 'left-right' position is not linear.

This PR is together with:
Soccer
Keisan

and later on in akushon.

Type of Change

  • Bugfix
  • Enhancement
  • New feature
  • Breaking change (fix or feature that would cause the existing functionality to not work as expected)

How Has This Been Tested?

  • New unit tests added.
  • Manual tested.

Checklist:

  • Using Branch Name Convention
    • feature/JIRA-ID-SHORT-DESCRIPTION if has a JIRA ticket
    • enhancement/SHORT-DESCRIPTION if has/has no JIRA ticket and contain enhancement
    • hotfix/SHORT-DESCRIPTION if the change doesn't need to be tested (urgent)
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have made the documentation for the corresponding changes.

Mobilizes and others added 16 commits May 16, 2024 22:09
…suiryoku into feature/adjust-function-for-dynamic-kick
…:ichiro-its/suiryoku into feature/adjust-function-for-dynamic-kick
…o-its/suiryoku into feature/adjust-function-for-dynamic-kick
@FaaizHaikal FaaizHaikal force-pushed the feature/adjust-function-for-dynamic-kick branch from 188fbf4 to 7410719 Compare June 25, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants