Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Remove unnecessary variable #14

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[Enhancement] Remove unnecessary variable #14

wants to merge 2 commits into from

Conversation

maroqijalil
Copy link
Member

@maroqijalil maroqijalil commented Jun 6, 2023 •
edited by Mobilizes
Loading

Jira Link:

Description

Remove the unnecessary is_calibrated variable from the Robot model and standardize node definitions by calling static helper from the related node.

Type of Change

  • Bugfix
  • Enhancement
  • New feature
  • Breaking change (fix or feature that would cause the existing functionality not to work as expected)

How Has This Been Tested?

  • New unit tests added.
  • Manual tested.

Checklist:

  • Using Branch Name Convention
    • feature/JIRA-ID-SHORT-DESCRIPTION if it has a JIRA ticket
    • enhancement/SHORT-DESCRIPTION if has/has no JIRA ticket and contains enhancement
    • hotfix/SHORT-DESCRIPTION if the change doesn't need to be tested (urgent)
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have made the documentation for the corresponding changes.

@maroqijalil maroqijalil self-assigned this Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@maroqijalil maroqijalil

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@maroqijalil