-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Sprint 22 / PD-401] [Enhancement] Update Github Workflows #34
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good in this PR, but it would be better if you could also remove the other unused workflow.
Regarding the failed workflow run, it seems that it was caused by an unused include in this line:
#include <kansei_interfaces/msg/fallen.hpp> |
Removing that should likely fix the build issue. However, you can fix this in another PR though.
ef914d6
to
f33c7e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test is failing in Keisan, try to fix this first. The other tests from other packages are also failing.
Jira Link:
https://ichiro-its.atlassian.net/jira/software/c/projects/PD/boards/4?selectedIssue=PD-401
Description
update github workflow using ros2-ws-action
Type of Change
How Has This Been Tested?
Checklist:
feature/JIRA-ID-SHORT-DESCRIPTION
if has a JIRA ticketenhancement/SHORT-DESCRIPTION
if has/has no JIRA ticket and contain enhancementhotfix/SHORT-DESCRIPTION
if the change doesn't need to be tested (urgent)