-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Sprint 22 / PD-369] - [Feature] Create gRPC-web Client on Akushon App #24
Open
FaaizHaikal
wants to merge
43
commits into
master
Choose a base branch
from
feature/using-grpc
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayantiTA
requested changes
Oct 30, 2023
Good UI 👍🏻 |
borednuna
reviewed
Nov 21, 2023
JayantiTA
approved these changes
Apr 2, 2024
threeal
reviewed
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Link
https://ichiro-its.atlassian.net/browse/PD-369
Description
Previously, we used the Kumo-app as a communication bridge between Akushon and Akushon-app. However, this feature has proven to be unreliable due to its enormous latency.
The following changes are included in this pull request:
The gRPC and gRPC-web methods have significantly improved latency, reducing it to around 20-30ms for their services.
Type of Change
Screenshots
UI Changes
BEFORE
AFTER
How Has This Been Tested?
Checklist
feature/JIRA-ID-SHORT-DESCRIPTION
if has a JIRA ticketenhancement/SHORT-DESCRIPTION
if has/has no JIRA ticket and contain enhancementhotfix/SHORT-DESCRIPTION
if the change doesn't need to be tested (urgent)