Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Custom fonts support in TextStyle fixes #6 #262

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

kkalisz
Copy link

@kkalisz kkalisz commented Jul 14, 2020

Hi,

this is draft of support for custom fonts in TextStyle.
My main concern now is about how to ( or even should we ) support custom font with and ** fontStyle** at the same time.
Basically we can include different types of fonts with only one text style, or with multiple font styles. I think that currently there is no even easy way to do it on any of the platforms. We can use typeface on android and symbolicTraits on iOS and add some fallbacks to default font. But personally it think that (at least for now) we should skip fontStyle when custom font is set.
Main reasons for that:

  • mocko-resources requires adding font files with single fontstyle
  • combining both properties will add additional complexity
  • in most cases developers will add/set custom font with given font style directly ( not by combining both properties)

What do you think ?

I will continue my work, when there will be decision which path should we follow.

@kkalisz kkalisz changed the title custom fonts support in TextStyle fixes #6 Custom fonts support in TextStyle fixes #6 Jul 14, 2020
@kkalisz kkalisz changed the title Custom fonts support in TextStyle fixes #6 [WIP] Custom fonts support in TextStyle fixes #6 Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants