[WIP] Custom fonts support in TextStyle fixes #6 #262
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this is draft of support for custom fonts in TextStyle.
My main concern now is about how to ( or even should we ) support custom font with and ** fontStyle** at the same time.
Basically we can include different types of fonts with only one text style, or with multiple font styles. I think that currently there is no even easy way to do it on any of the platforms. We can use typeface on android and symbolicTraits on iOS and add some fallbacks to default font. But personally it think that (at least for now) we should skip fontStyle when custom font is set.
Main reasons for that:
What do you think ?
I will continue my work, when there will be decision which path should we follow.