Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating the methods of NumberInput and TypedInput #310

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Updating the methods of NumberInput and TypedInput #310

merged 2 commits into from
Dec 3, 2024

Conversation

Ultraxime
Copy link
Contributor

I add all the relevant methods of TextInput in NumberInput and TypedInput

I did not add the secure method for NumberInput as I thought it was not relevant

Ultraxime and others added 2 commits December 3, 2024 12:30
@Ultraxime
Matching the method of number_input and typed_input with the one of t…
10a067d 
…ext_input

NumberInput does not get the secure method as it does not make sens to have a secure number input
@Ultraxime
Merge branch 'iced-rs:main' into main
32613c7
genusistimelord
genusistimelord approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@genusistimelord genusistimelord left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

The Secure method makes no sense here as its a number or Type input and not a password input.

@genusistimelord genusistimelord merged commit 9fe902e into iced-rs:main Dec 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@genusistimelord genusistimelord genusistimelord approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ultraxime @genusistimelord