Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid a number of crashes due to menu changes while menu is open. #307

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

andrewdavidmackenzie
Copy link
Contributor

Fixes #301

Copy link
Collaborator

@genusistimelord genusistimelord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a decent way to fix these issues.
Thank you and yes I always accept PR's that are properly handled.

@andrewdavidmackenzie
Copy link
Contributor Author

Ok, great, you're welcome.

I'll watch out for a release, so I can stop using my fork in my app.

@genusistimelord genusistimelord merged commit 6159b55 into iced-rs:main Nov 27, 2024
2 checks passed
@genusistimelord
Copy link
Collaborator

you can use the main git now since its merged. But if you see or Feel something needs to be fixed and have a potential solution to it always feel free to submit a PR for it. I do go through and review all the changes before i accept any of them.

@andrewdavidmackenzie andrewdavidmackenzie deleted the fix_menu_crash branch December 12, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unwrap in menu overlay causes app to crash
2 participants