Allow disabling scroll events for NumberInput. #239
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#223
Simply allows disabling mouse scroll events for the
NumberInput
. Not sure how needed this is, but I can see it being annoying where the outer scrollable is small, as the user could accidentally modify the value.The issue also mentions the idea of the event being opt-in, instead of opt-out which can be changed in
NumberInput::new
if preferred. Though personally I don't think its worth changing default behavior.