Fix number input over/underflow #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
genusistimelord
previously approved these changes
Apr 27, 2024
|
fix the clippy issue and you should be good. |
|
It should be fixed now. |
genusistimelord
approved these changes
Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #235.
This code change makes sure to not do any operations that might overflow or underflow.
The code makes the assumption that it does not receive the widget in a broken state, ie the invariant
must be true for the code to be correct. If it is, then the result after the operation will uphold the same invariant.
Such a topic is very error prone, so please feel free to try and find problems in the code I wrote.