Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only activate required iced-features #224

Merged
merged 1 commit into from
Mar 17, 2024
Merged

Conversation

spamviech
Copy link
Contributor

@spamviech spamviech commented Mar 17, 2024

They are automatically activated for users of this crate.

My specific use-case:
For some reason, starting with iced-0.12 activating the wgpu-feature results in a "unwrap on a None-value" panic when executing on a rasperry pi.
Additionally, I don't want to activate the "tokio"-feature, since I don't use it for anything else (yet), and tokio isn't exactly small.

All examples are still compiling (added missing "icons"-feature where rustc was complaining).
However, I noticed some weirdness (not addressed here, to keep the scope small):

  • wgpu requirement in examples:
    • panic on tab_bar (start) and multiple_modals (after button press)
    • sometimes starts with black window
    • color-picker bottom line stays empty
    • menu: when focusing an item, every other item is only a black box
  • cuppertino_switch has weird behaviour (e.g. toggling both visually)
  • split_scroller
    • panics when used with "wgpu" feature
    • horizontal scrolling is not shown in slidebar at the bottom
  • folder for slidebar is named sliderbar (extra "r" in the middle)
  • folder for widget_id is named WidgetIDReturn

Copy link
Collaborator

@genusistimelord genusistimelord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a reasonable change, thank you

@genusistimelord genusistimelord merged commit 7311ccc into iced-rs:main Mar 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants